Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conflict handling #154

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Conversation

Morganamilo
Copy link
Contributor

@Morganamilo Morganamilo commented Feb 16, 2018

Renable conflict checking, was disabled for testing, forgot to reenable
Use pacman --ask to remove conflicting packages, dont do it directly.
Say what each package conflicts with
Check for conflicts before aking for clean build

Reverse conflict are still not checked

Example output:
image

Relies on Jguer/go-alpm#4

Renable conflict checking, was disabled for testing, forgot to reenable
Use pacman --ask to remove conflicting packages, dont do it directly.
Say what each package conflicts with
Check for conflicts before aking for clean build

Reverse conflict are still not checked
@Jguer Jguer merged commit 25eb2e2 into Jguer:master Feb 17, 2018
@Morganamilo Morganamilo deleted the handleconflicts branch February 18, 2018 01:44
@Morganamilo
Copy link
Contributor Author

@AladW You closed the talk section so I'll just link you here. This commit removed -Rdd, less that 10 days after it was added in the first place.

I pointed this out and was ignored

I don't remember you pointing it out anywhere here. May you're confused with trizen? trizen/trizen@ba687bc

@AladW
Copy link
Contributor

AladW commented Mar 28, 2018

I mentioned in the comments of the commit adding -Rdd

edit: note that "closing" a discussion on the wiki just means that someone might remove it after 7 days, the page can still be edited. I closed it since in the end everyone kept repeating their own points without progress otherwise, and having a yellow entry + explanation instead of a red or green entry seemed a reasonable compromise.

@Morganamilo
Copy link
Contributor Author

This commit? 28515c8b

@AladW
Copy link
Contributor

AladW commented Mar 28, 2018

right, 28515c8?diff=unified#r27587686

@Morganamilo
Copy link
Contributor Author

Ah right, was in the middle of the page so I missed it some how. Sorry about that. Would like to point out that It was removed the day after that comment.

@AladW
Copy link
Contributor

AladW commented Mar 28, 2018

Changed the entry to "partial" then for now. If #130 is implemented yay should be back to the top section of the table

@Morganamilo
Copy link
Contributor Author

#146 Is fixed in the git only, that's why I had not changed the wiki myself. We're due a release in a day so I don't know if it's worth the effort of changing it back.

@AladW
Copy link
Contributor

AladW commented Mar 28, 2018

Eh, don't worry about it. Thanks for making those improvements.

@AladW
Copy link
Contributor

AladW commented Mar 28, 2018

Oh, I see what you mean now. The wiki table used to have entries by name only, not actual AUR packages. So it should probably reflect how the release version performs as you say.

As I agree it's not worth changing back the colors, I've just added a "yay-git" to the entry.

@Morganamilo
Copy link
Contributor Author

Yeah that seems like the best way to do it. As long as the table doesn't end up getting flooded with helper-git* exceptions dotted around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants