Remove package from VCS on failed install #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @davejab , that part of the code is not very healthy so I'm ok to accept this patch, I can't think of a better way to solve it in the current architecture ( would prefer a single point where this would be evaluated). If you can just fix up the linting, I'll merge it, thanks 👍 |
davejab
changed the title
|
@Jguer thanks for reviewing, I have fixed the linting errors, if there is anything else let me know 👍 |
Jguer
approved these changes
Sep 3, 2022
|
Thanks @davejab for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1676