fix(pre-commit): update URL and versions in the pre-commit configuration #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a dead link in the pre-commit-golang URL. Also, Woile/commitizen redirects to commitizen-tools/commitizen, so change that URL as well. Last, update all the versions using pre-commit autoupdate. This will make it easier for new contributers to use the pre-commit hooks when contributing.
Jguer
approved these changes
Dec 27, 2022
|
I see, weird that it's working in the CI, I'll investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a dead link in the
pre-commit-golangURL, which causedpre-commit installto fail. Also,Woile/commitizenredirects tocommitizen-tools/commitizen, so change that URL as well. Last, update all the versions usingpre-commit autoupdate. All hooks still pass.This will make it easier for new contributors to use the pre-commit hooks when contributing.
Last, I noticed that the
news_test.gounit test doesn't work in some timezones (e.g. it works inEurope/Parisbut not inAmerica/Denver). This causes the pre-commit hook to fail. Wanted to mention this in case other contributors from different timezones run into this issue (or this is an actual issue within the news code).