fix(aur_install): fix debug packages being added to deps even if not found #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes another edge case with debug packages:
If debug packages are enabled (option
debug strip),makepkg --packagelistwill always list a -debug package as one of the built packages. However,makepkgwill not always build one. If the package does not contain any files from which debug information can be extracted, there will not be a debug package.yaywas correctly checking for this with thestatcheck ingetNewTargets, but didn't update theokvariable when it wasn't found, leading to errors finding the packages when setting the install reason later (because they do not exist, but were added to the list anyway).This PR fixes this by just setting the bool correctly.