-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version diff word detection #2124
Merged
Jguer
merged 3 commits into
Jguer:next
from
tchaudhry91:fix-version-diff-word-detection
Apr 27, 2023
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
package query | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/Jguer/yay/v12/pkg/text" | ||
) | ||
|
||
func TestVersionDiff(t *testing.T) { | ||
testCases := []struct { | ||
name string | ||
a string | ||
b string | ||
wantDiff string | ||
}{ | ||
{ | ||
name: "1.0.0-1 -> 1.0.0-2", | ||
a: "1.0.0-1", | ||
b: "1.0.0-2", | ||
wantDiff: "1.0.0-" + text.Red("1") + " " + "1.0.0-" + text.Green("2"), | ||
}, | ||
{ | ||
name: "1.0.0-1 -> 1.0.1-1", | ||
a: "1.0.0-1", | ||
b: "1.0.1-1", | ||
wantDiff: "1.0." + text.Red("0-1") + " " + "1.0." + text.Green("1-1"), | ||
}, | ||
{ | ||
name: "3.0.0~alpha7-3 -> 3.0.0~alpha7-4", | ||
a: "3.0.0~alpha7-3", | ||
b: "3.0.0~alpha7-4", | ||
wantDiff: "3.0.0~alpha7-" + text.Red("3") + " " + "3.0.0~alpha7-" + text.Green("4"), | ||
}, | ||
{ | ||
name: "3.0.0~beta7-3 -> 3.0.0~beta8-3", | ||
a: "3.0.0~beta7-3", | ||
b: "3.0.0~beta8-3", | ||
wantDiff: "3.0.0~" + text.Red("beta7-3") + " " + "3.0.0~" + text.Green("beta8-3"), | ||
}, | ||
{ | ||
name: "23.04.r131.b1bfe05-1 -> 23.04.r131.b1bfe07-1", | ||
a: "23.04.r131.b1bfe05-1", | ||
b: "23.04.r131.b1bfe07-1", | ||
wantDiff: "23.04.r131." + text.Red("b1bfe05-1") + " " + "23.04.r131." + text.Green("b1bfe07-1"), | ||
}, | ||
{ | ||
name: "1.0.arch0-1 -> 1.0.arch1-2", | ||
a: "1.0.arch0-1", | ||
b: "1.0.arch1-2", | ||
wantDiff: "1.0." + text.Red("arch0-1") + " " + "1.0." + text.Green("arch1-2"), | ||
}, | ||
} | ||
for _, tc := range testCases { | ||
t.Run(tc.name, func(t *testing.T) { | ||
left, right := GetVersionDiff(tc.a, tc.b) | ||
gotDiff := left + " " + right | ||
if gotDiff != tc.wantDiff { | ||
t.Errorf("VersionDiff(%s, %s) = %s, want %s", tc.a, tc.b, gotDiff, tc.wantDiff) | ||
} | ||
}) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to force
text.Color = true
and then unset it at the end of the test to stop the automatic tty detection from turning off colors.One of the unfortunate places where we haven't gotten rid of globals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the change.