Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps resolving for installs from SRCINFO #2190

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

smolx
Copy link
Contributor

@smolx smolx commented May 24, 2023

Fixed in the same way as for recent fix of AUR dependencies(#2157).
Also added new test case and slightly fixed a few old ones.

@smolx smolx requested a review from Jguer as a code owner May 24, 2023 14:22
@smolx smolx force-pushed the fix-deps-resolving-for-srcinfo-installs branch from 568c2e4 to b472523 Compare May 24, 2023 14:34
Also made MockBuilder and MockRunner thread-safe.
@smolx smolx force-pushed the fix-deps-resolving-for-srcinfo-installs branch from b472523 to 40d1135 Compare May 26, 2023 11:29
@smolx
Copy link
Contributor Author

smolx commented May 26, 2023

@Jguer I had to redo the fix, because previously I did not take into account a case with several .SRCINFO targets. It turned out to be a little more complicated, but still it's tested and works. I also made MockRunner(and MockBuilder just in case) thread-safe to make a new test-scenario work.

Copy link
Owner

@Jguer Jguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go :), great PR

@Jguer Jguer merged commit 0607090 into Jguer:next Jun 3, 2023
@smolx smolx deleted the fix-deps-resolving-for-srcinfo-installs branch June 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants