Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling targets with specified db #2218

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

smolx
Copy link
Contributor

@smolx smolx commented Jun 21, 2023

Handle it in a similar way to handling targets with unspecified db.

Also refactored GraphSyncPkg method to make stuff more DRY.

It doesn't compile because it requires changes to be made in go-alpm: Jguer/go-alpm#62. I think it's good to have both PRs to see the full picture.

Handle it in a similar way to handling targets with unspecified db.

Also refactored GraphSyncPkg method to make stuff more DRY.
@Jguer
Copy link
Owner

Jguer commented Jul 6, 2023

👍 looks good, tried some scenarios locally, let's merge it and go from there :)

@Jguer Jguer merged commit 6dd7933 into Jguer:next Jul 6, 2023
@smolx
Copy link
Contributor Author

smolx commented Jul 7, 2023

Oops. It was merged without many words. I expected some remarks or discussion. :)
OK then. I'll raise one question here myself.
While working on this I've noticed dubious behavior. When user tries to install several targets and one of them is not found(for example user makes a typo), yay just skips it with non-fatal error message("AUR package not found", even if user implied a repo target) and proceeds to install other targets. Inattentive user may get an undesirable result. Is it intended feature? Wouldn't it be better to show all error messages for not found targets and just exit like for example pacman does?

@Jguer
Copy link
Owner

Jguer commented Jul 17, 2023

Wouldn't it be better to show all error messages for not found targets and just exit like for example pacman does

I agree with this statement. There was a lot of feedback though on how yay should ignore failed builds and not found targets specially from users that maintain a list of AUR packages to install on newly bootstrapped systems.

I see merit to both arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants