Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7953e better form editor #580

Merged
merged 10 commits into from
Sep 23, 2024
Merged

7953e better form editor #580

merged 10 commits into from
Sep 23, 2024

Conversation

JhumanJ
Copy link
Owner

@JhumanJ JhumanJ commented Sep 23, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced drag-and-drop functionality for adding blocks with improved settings control.
    • Introduced methods for removing fields, including an undo option for user convenience.
  • Bug Fixes

    • Adjusted behavior for opening settings when a new block is added, providing a more intuitive user experience.

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to the handleDragDropped method in the OpenForm.vue component and the addBlock method in the working_form.js store. The addBlock method now accepts an additional boolean parameter, openSettings, which determines if the settings for the newly added block should be opened. Two new methods, removeField and internalRemoveField, have also been introduced to facilitate field removal from the properties array, enhancing the overall functionality of the store.

Changes

File Change Summary
client/components/open/forms/OpenForm.vue Updated handleDragDropped to include an additional parameter in the addBlock method call.
client/stores/working_form.js Modified addBlock method to include openSettings parameter; added removeField and internalRemoveField methods.

Possibly related PRs

🐇 In the code we play,
With blocks that come and stay,
A little tweak here, a change so bright,
Settings open, what a delight!
Fields can hop away with ease,
In our store, we code with glee! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JhumanJ JhumanJ merged commit 5dcd4ff into main Sep 23, 2024
4 checks passed
@JhumanJ JhumanJ deleted the 7953e-better-form-editor branch September 23, 2024 18:15
@coderabbitai coderabbitai bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants