Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.setContents miserably fails ;-( #1118

Closed
PierreKauffmann opened this issue Nov 2, 2022 · 5 comments
Closed

Object.setContents miserably fails ;-( #1118

PierreKauffmann opened this issue Nov 2, 2022 · 5 comments
Milestone

Comments

@PierreKauffmann
Copy link

Using

"suneditor": "2.44.3",
"suneditor-react": "3.4.1",

Error

TypeError: Cannot read properties of null (reading 'replaceChild')
    at Object.update_image (image.js:793:45)
    at Object.<anonymous> (image.js:629:38)
    at Object.checkInfo (fileManager.js:141:21)
    at Object.checkFileInfo (image.js:633:44)
    at Object._checkComponents (core.js:5730:44)
    at f (history.js:55:14)
    at Object.push (history.js:114:21)
    at Object.setContents (core.js:5057:30)
    at Object.setContents (core.js:8721:18)
    at Ue (EditMessageItem.js:537:10)

Our code is EditMessageItem.js
editor.setContents(newContent);

newContent is an HTML TEXT

<a
  download="README"
  href="https://github.com/JiHong88/SunEditor/blob/master/README.md"
  target="_blank"
>
  <img
    src="https://google.com"
    alt="icon1"
  />
  <img
    src="https://google.com"
    alt="icon2"
  />
</a>

It works with 1 image in the <a ...> tag !!!

Should be easy and super fast to fix ;-)

@JiHong88 JiHong88 added this to the 2.44.4 milestone Nov 3, 2022
@PierreKauffmann
Copy link
Author

THX @JiHong88 to put this in the next milestone ;-)

@PierreKauffmann
Copy link
Author

Is there a target date for the 2.44.4 milestone?

@JiHong88
Copy link
Owner

Sorry, I had a lot of busy work.
Updated milestone dates.

https://github.com/JiHong88/SunEditor/milestone/51

@PierreKauffmann
Copy link
Author

THX for all the hard work, looking forward to see it ;-)

JiHong88 added a commit that referenced this issue Mar 17, 2023
@JiHong88
Copy link
Owner

The 2.44.4 version has been updated.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants