Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read only mode - enter button press #1234

Closed
CasperKZP opened this issue Apr 24, 2023 · 2 comments
Closed

Read only mode - enter button press #1234

CasperKZP opened this issue Apr 24, 2023 · 2 comments
Labels
bug
Milestone
2.45.0

Comments

@CasperKZP
Copy link

In read only mode, when we press enter button we can change the text.

  1. Go to http://suneditor.com/sample/html/examples.html#functions
  2. Click on ReadOnly button
  3. Select the text and press Enter
  4. Text changed

Expected behavior
Dont change the text in read only mode.

Screenshots

  1. image
  2. image
  3. image
  4. image
@CasperKZP
Copy link
Author

CasperKZP commented Apr 24, 2023 •
edited
Loading

I think this code is lead to error

lib/core.js / 6843

 if (!ctrl && core.isReadOnly && !event._directionKeyCode.test(keyCode)) {

@JiHong88 JiHong88 added the bug label Apr 24, 2023
@JiHong88 JiHong88 added this to the 2.45.0 milestone Apr 24, 2023
JiHong88 added a commit that referenced this issue May 30, 2023
@JiHong88
fix: #1234 readOnly - enter key bug
ef06c3d
@JiHong88
Copy link
Owner

The 2.45.0 version has been updated.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.45.0
Development

No branches or pull requests
2 participants
@JiHong88 @CasperKZP