enh: much better fileComponent keyboard experience #1267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is selected component (by resizing controls):
Logic there is the same as for text nodes - it acts like if the component/image is a selected range of text. Unification.
@JiHong88, try it. It is pretty nice and intuitive right now! This is the behavior I was expecting by default.
P.S. I hope my way to remove/destroy the container is sufficient (on typing text keys):
util.changeElement(container, format);
New behavior also prevents some nasty bugs and oddities on typing text when resize controls are active. Try it with other PR's altogether.