Fix access specifiers between CBS.h/ECBS.h #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `terminate()` on `ECBS` object caused a segfault because `terminate()` is implemented by the base class `CBS`. This method called `printPaths()` (from the base implementation) which caused the segfault since the member variable `paths_found_initially` from the base implementation was empty. To make matters confusing, the base class had a protected variable `paths_found_initially` but the subclass "shadows" this variable by defining a private variable with the same name (`paths_found_initially`) but a different type. This change updates access specifiers to align with usage and prevent segfault when `CBS::terminate()` is called from a subclass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
terminate()onECBSobject caused a segfault becauseterminate()is implemented by the base classCBS. This method calledprintPaths()(from the base implementation) which caused the segfault since the member variablepaths_found_initiallyfrom the base implementation was empty.To make matters confusing, the base class had a protected variable
paths_found_initiallybut the subclass "shadows" this variable by defining a private variable with the samename (
paths_found_initially) but a different type.This change updates access specifiers to align with usage and prevent segfault when
CBS::terminate()is called from a subclass.Fixes #2