Skip to content

Commit

Permalink
Don't make the upgrader global.
Browse files Browse the repository at this point in the history
  • Loading branch information
sbruens committed Jan 30, 2025
1 parent 5975997 commit 8506f49
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions x/websocket/endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ import (
"github.com/gorilla/websocket"
)

// defaultUpgrader is a pre-configured instance which provides reasonable default
// values for various WebSocket upgrade parameters.
var defaultUpgrader = websocket.Upgrader{}

// NewStreamEndpoint creates a new Websocket Stream Endpoint. Streams are sent over
// Websockets, with each Write becoming a separate message. Half-close is supported:
// CloseRead will not close the Websocket connection, while CloseWrite sends a Websocket
Expand Down Expand Up @@ -203,7 +199,8 @@ func (c *gorillaConn) Close() error {
// [transport.StreamConn] representing the WebSocket connection, or an error if
// the upgrade fails.
func Upgrade(w http.ResponseWriter, r *http.Request, responseHeader http.Header) (transport.StreamConn, error) {
wsConn, err := defaultUpgrader.Upgrade(w, r, responseHeader)
upgrader := websocket.Upgrader{}
wsConn, err := upgrader.Upgrade(w, r, responseHeader)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 8506f49

Please sign in to comment.