Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transport): general TLS ClientHello fragmentation StreamDialer #133
feat(transport): general TLS ClientHello fragmentation StreamDialer #133
Changes from 4 commits
dee4db7
603eaf9
779fe68
1ff2fed
725c3fe
653b855
2ed8304
4bc8f2c
5a687a0
ddf46f0
4f00ec8
edb97bb
87c3592
cb8e9f3
8c0063d
2598369
5e6aa87
fb75111
c371139
0314269
19240a9
16d2d9b
711162d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't you returning on error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because according to the doc https://pkg.go.dev/io#Reader:
In our case, "processing" means determine whether we have read a full header or a full record. After that, we will jump out of the loop when
err != nil
(see the condition infor
loop).