Newlevel safetoken #10
Conversation
JithinKS97
force-pushed
the
newlevel-safetoken
branch
2 times, most recently
from
caa1895 to
5dfb2c0
Compare
|
|
||
|
|
||
| Things that might help: | ||
| * An [EVM bytecode decompiler](https://ropsten.etherscan.io/bytecode-decompiler?a=) |
There was a problem hiding this comment.
Ropsten is deprecated, maybe is worth changing it for some other tool ? or the same from etherscan but in another chain
There was a problem hiding this comment.
Yes sure, I'll look at that.
client/src/gamedata/authors.json
Outdated
| @@ -147,6 +147,11 @@ | |||
| "websites": [ | |||
| "https://www.linkedin.com/in/kstasi/" | |||
| ] | |||
| }, | |||
| "AshiqAmien": { | |||
| "name": "Ashiq Amien", | |||
There was a problem hiding this comment.
Are all these meant to be arrays instead of single key values ?
There was a problem hiding this comment.
Oh thanks for the catch, changing now
client/src/gamedata/gamedata.json
Outdated
| "revealCode": true, | ||
| "deployParams": [], | ||
| "deployFunds": 0, | ||
| "deployId": "29", |
There was a problem hiding this comment.
Yes, we can merge this once 546 is merged. I will rebase it with master once 546 is merged.
There was a problem hiding this comment.
Yes but we need to change deployId to 30
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| import '@openzeppelin/contracts/token/ERC20/ERC20.sol'; |
There was a problem hiding this comment.
Shouldn't this import be similar to the one of SafeTokenBackdoor ?
There was a problem hiding this comment.
Yes both are basically, same, we have
import 'openzeppelin-contracts-08/token/ERC20/ERC20.sol'; and
import '@openzeppelin/contracts/token/ERC20/ERC20.sol';
To keep things consistent, we will keep it the same.
JithinKS97
force-pushed
the
newlevel-safetoken
branch
4 times, most recently
from
4c8e16c to
ef69a3a
Compare
JithinKS97
force-pushed
the
newlevel-safetoken
branch
from
ef69a3a to
d1a5032
Compare
moved files upgraded solidity levels upgraded contracts corrected the tests changed bytecode decompiler added review comment changes added images
JithinKS97
force-pushed
the
newlevel-safetoken
branch
from
d1a5032 to
f295f9b
Compare
JithinKS97
force-pushed
the
master
branch
12 times, most recently
from
edaa0f7 to
5b14709
Compare
Added the following changes on top of OpenZeppelin#193