Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#define WS2812_GAMMA_CORRECTION doesn't do anything #9

Open
scottlawsonbc opened this issue Dec 31, 2016 · 0 comments · May be fixed by #10
Open

#define WS2812_GAMMA_CORRECTION doesn't do anything #9

scottlawsonbc opened this issue Dec 31, 2016 · 0 comments · May be fixed by #10

Comments

@scottlawsonbc
Copy link

#define WS2812_GAMMA_CORRECTION in ws2812.h isn't referenced by any other file and does not appear to change anything. The correct behaviour is that WS2812_GAMMA_CORRECTION should enable or disable gamma correction.
scottlawsonbc added a commit to scottlawsonbc/esp8266_ws2812_i2s that referenced this issue Jan 7, 2017
@scottlawsonbc
Added more detail to comments, note about gamma correction bug
ed21217 
Added more detailed comments for the options in `ws2812.h`. Added note
indicating that you cannot disable gamma correction (related to
JoDaNl#9).
@scottlawsonbc scottlawsonbc linked a pull request Jan 8, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed bugs, added lots of documentation scottlawsonbc/esp8266_ws2812_i2s
1 participant
@scottlawsonbc