Skip to content

Commit

Permalink
Pass an executor to SsdFile (facebookincubator#9710)
Browse files Browse the repository at this point in the history
Summary:
Checkpoint relies on the executor to schedule a potentially long
fsync of cache file on another thread. Currently it is not set.

Pull Request resolved: facebookincubator#9710

Reviewed By: xiaoxmeng

Differential Revision: D56965318

Pulled By: zacw7

fbshipit-source-id: 13f50f08c840e7a92fcede3ecb2f4ce63caa044e
  • Loading branch information
zacw7 authored and facebook-github-bot committed May 6, 2024
1 parent e38079f commit 9fde0a2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion velox/common/caching/SsdCache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ SsdCache::SsdCache(
i,
fileMaxRegions,
checkpointIntervalBytes / numShards,
disableFileCow));
disableFileCow,
executor_));
}
}

Expand Down

0 comments on commit 9fde0a2

Please sign in to comment.