Skip to content

Commit

Permalink
Update function signature
Browse files Browse the repository at this point in the history
  • Loading branch information
czentgr authored and Joe-Abraham committed Jun 7, 2024
1 parent d670da3 commit d6d5be4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions velox/expression/SimpleFunctionAdapter.h
Original file line number Diff line number Diff line change
Expand Up @@ -968,6 +968,8 @@ class SimpleFunctionAdapterFactoryImpl : public SimpleFunctionAdapterFactory {
public:
// Exposed for use in FunctionRegistry
using Metadata = typename UDFHolder::Metadata;
static constexpr bool isDefaultNullBehavior =
UDFHolder::is_default_null_behavior;

explicit SimpleFunctionAdapterFactoryImpl() {}

Expand Down
10 changes: 10 additions & 0 deletions velox/functions/CoverageUtil.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,19 @@

#include <string>
#include <unordered_set>
#include <vector>

namespace facebook::velox::functions {

// Returns sorted list of scalar function names available in Velox.
std::vector<std::string> getSortedScalarNames();

// Returns sorted list of aggregate function names available in Velox.
std::vector<std::string> getSortedAggregateNames();

// Returns sorted list of window function names available in Velox.
std::vector<std::string> getSortedWindowNames();

// Print a rst format string which contains all Presto/Spark scalar
// functions and aggragate functions. This function will read
// all_scalar_functions.txt and all_aggregate_functions.txt from certain path.
Expand Down

0 comments on commit d6d5be4

Please sign in to comment.