Skip to content

Commit

Permalink
Allow offline pre-compilation of 'xsimd' dependency (facebookincubato…
Browse files Browse the repository at this point in the history
…r#8308)

Summary:
`set(xsimd_SOURCE BUNDLED)` will force the 'xsimd' library to be
compiled from source, but this will make it impossible to compile Velox
offline. We should use `set_source(xsimd)` so that it respects the
`VELOX_DEPENDENCY_SOURCE` global cmake variable.

If it is really needed to force the 'xsimd' library to be compiled from
source in a certain environment, use the following method to achieve it.

```
cmake -Dxsimd_SOURCE=BUNDLED ...
```

Pull Request resolved: facebookincubator#8308

Reviewed By: Yuhta

Differential Revision: D53320172

Pulled By: kgpai

fbshipit-source-id: 8f9fb975ef33ab9596facd1283151f060de545b7
  • Loading branch information
lingbin authored and facebook-github-bot committed Feb 2, 2024
1 parent e0cf6e9 commit f9e9464
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .circleci/dist_compile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ jobs:
VELOX_DEPENDENCY_SOURCE: SYSTEM
ICU_SOURCE: BUNDLED
simdjson_SOURCE: BUNDLED
xsimd_SOURCE: BUNDLED
DuckDB_SOURCE: SYSTEM
steps:
- pre-steps
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -544,8 +544,8 @@ if(NOT VELOX_DISABLE_GOOGLETEST)
PARENT_SCOPE)
endif()

set(xsimd_SOURCE BUNDLED)
resolve_dependency(xsimd)
set_source(xsimd)
resolve_dependency(xsimd 10.0.0)

if(VELOX_BUILD_TESTING)
set(BUILD_TESTING ON)
Expand Down

0 comments on commit f9e9464

Please sign in to comment.