Remove dependency to bean validation for message types #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohT
force-pushed
the
feature/bean-validation-removed
branch
from
a23b918
to
96462fd
Compare
JohT
force-pushed
the
feature/bean-validation-removed
branch
from
4bd0beb
to
8713711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message value objects for commands, events and queries will likely be shared across command- and query-side parts of the application. To get these to only depend on java itself, bean validation will be removed. Instead null validation will be done inside the constructor. This has the additional advantage that an exception is thrown early when the object (e.g. a command) is created with a null value and not later when the command gets dispatched.
For reference, the use of bean validation is documented and can still be viewed in version V1.4.0 and earlier.