Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to H2 version 2.1, Automate PostgreSQL build and test, Update Code Coverage #79

Merged
merged 9 commits into from
May 20, 2022

Conversation

JohT
Copy link
Owner

@JohT JohT commented May 18, 2022

Changes

Migration to H2 version 2.1

As documented in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.9 and more detailed in http://www.h2database.com/html/migration-to-v2.html there are some migration steps necessary to update H2 to its new major version 2.

  • Rename database columns from "timestamp" to "eventtimestamp" to avoid conflicts with reserved words
  • Use quotes for case-sensitive database schema names
  • Document additional command line parameter "-ifNotExists" for local H2 database start
  • Use upper-case column names for H2

Continuous Integration Workflow for PostgeSQL

  • Add new workflow to build and test with PostgreSQL database based on Creating PostgreSQL service containers
  • Use PhantomJS 2.1.1 that supports linux, since the new workflow runs within a linux docker container
  • Provide configurable database hostname and port via environment variables to connect to docker PostgreSQL service instead of localhost.

Update Code Coverage for tests

  • Update dependency org.jacoco:jacoco-maven-plugin to v0.8.8
  • Change <phase>test</phase> to <phase>post-integration-test</phase> in pom.xml for jacoco-check execution, so that all tests are included as before and branch coverage limit is met

@JohT JohT self-assigned this May 18, 2022
@JohT JohT force-pushed the update/h2-version-2 branch 3 times, most recently from 6d18fb9 to 1d2eefe Compare May 20, 2022 12:35
@JohT JohT changed the title Update and migrate H2 to version 2.1 Migrate to H2 version 2.1, Automate PostgreSQL build and test, Update Code Coverage May 20, 2022
@JohT JohT merged commit b598512 into master May 20, 2022
@JohT JohT deleted the update/h2-version-2 branch May 20, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants