Add list of contributors to the README #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvdans
reviewed
May 23, 2024
…into create_contributor_list
…ott/impurityModel into create_contributor_list
fesorg
approved these changes
May 29, 2024
kalvdans
approved these changes
May 29, 2024
johanjoensson
approved these changes
May 30, 2024
JohanSchott
changed the title
|
Thanks @fesorg @johanjoensson and @kalvdans for reviewing and approving the PR. I added a commit where I corrected the github username for Petter Säterskog. |
PetterSaterskog
approved these changes
Jun 6, 2024
|
Thanks for all the reviews! I plan to merge in 2 days, unless something new pops up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several people have contributed to the impurityModel repo.
I thought it could be nice to recognise this by making a list of the people that have contributed in some way.
I also wrote down a very short description of each persons contribution (please feel free to edit, especially your own contribution description!).
@johanjoensson, @fesorg, @patrikthunstrom, @PetterSaterskog, @kalvdans, and @igordimarco, please let me know what you think about this PR.