render <br/> directly as hard-line-break

JohannesKaufmann · Dec 25, 2024 · e40d875 · e40d875
1 parent 5493558
commit e40d875
Show file tree

Hide file tree

Showing 8 changed files with 58 additions and 18 deletions.
diff --git a/plugin/commonmark/commonmark_test.go b/plugin/commonmark/commonmark_test.go
@@ -152,7 +152,7 @@ func TestOptionFunc(t *testing.T) {
 				commonmark.WithHeadingStyle("setext"),
 			},
 			input:    `<h1>important<br/>heading</h1>`,
-			expected: "important\n\\\nheading\n=========",
+			expected: "important\nheading\n=========",
 		},
 
 		// - - - - - - - - - - Link - - - - - - - - - - //

diff --git a/plugin/commonmark/render_break.go b/plugin/commonmark/render_break.go
@@ -2,12 +2,14 @@ package commonmark
 
 import (
 	"github.com/JohannesKaufmann/html-to-markdown/v2/converter"
-	"github.com/JohannesKaufmann/html-to-markdown/v2/marker"
 	"golang.org/x/net/html"
 )
 
 func (c *commonmark) renderBreak(_ converter.Context, w converter.Writer, _ *html.Node) converter.RenderStatus {
-	w.Write(marker.BytesMarkerLineBreak)
-	w.Write(marker.BytesMarkerLineBreak)
+	// w.Write(marker.BytesMarkerLineBreak)
+	// w.Write(marker.BytesMarkerLineBreak)
+	// w.WriteString("\n")
+
+	w.WriteString("  \n")
 	return converter.RenderSuccess
 }
diff --git a/plugin/commonmark/testdata/GoldenFiles/blockquote.out.md b/plugin/commonmark/testdata/GoldenFiles/blockquote.out.md
@@ -7,12 +7,19 @@
 <!--with one break-->
 
 > Line A  
-Line B
+> Line B
 
 <!--with multiple breaks-->
 
 > Start Line
 > 
+>   
+>   
+>   
+>   
+>   
+>   
+> 
 > End Line
 
 <!--large blockquote-->

diff --git a/plugin/commonmark/testdata/GoldenFiles/heading.out.md b/plugin/commonmark/testdata/GoldenFiles/heading.out.md
@@ -105,17 +105,14 @@ not title
 * * *
 
 > [**Heading 2**
-> \
 > **Heading 5**](/page.html)
 
 * * *
 
 > [**Heading 2**
 > \
 > Description Line 1
-> \
 > Description Line 2
-> \
 > Description Line 3
 > \
 > "Some quote"](/page.html)

diff --git a/plugin/commonmark/testdata/GoldenFiles/image.out.md b/plugin/commonmark/testdata/GoldenFiles/image.out.md
@@ -76,7 +76,7 @@
 
 <!--image inside a link-->
 
-[![image alt text](/image.jpg "image title text")](/page.html "link title text")
+[![image alt text](/image.jpg "image title text")](/page.html "link title text")  
 
 <!--image inside an empty link-->
 

diff --git a/plugin/commonmark/testdata/GoldenFiles/link.out.md b/plugin/commonmark/testdata/GoldenFiles/link.out.md
@@ -143,15 +143,39 @@ before [content](/) after
 
 [Start Line
 \
+\
+\
+\
+\
+\
+\
+\
 End Line](/)
 
 <!--newlines inside link-->
 
+
+
+
+
 [newlines around the link content](/)
 
+
+
+
+
 <!--multiline link inside a list item-->
 
 - [first text
+  \
+  \
+  \
+  \
+  \
+  \
+  \
+  \
+  \
   \
   second text](/)
 
@@ -170,8 +194,7 @@ second text](/page.html)
 <!--link with headings-->
 
 [**Heading A**
-\
-**Heading B**](/page.html)
+**Heading B**](/page.html)  
 
 <!--link with an svg-->
 

diff --git a/plugin/commonmark/testdata/GoldenFiles/list.out.md b/plugin/commonmark/testdata/GoldenFiles/list.out.md
@@ -11,8 +11,7 @@ A paragraph
 - - 5.1
 
   5 After
-- 6 Before
-
+- 6 Before  
   6 also Before
 
   - 6A.1
@@ -56,9 +55,8 @@ List Item without Container
 
 <!-- list with blockquote that contains break -->
 
-1. > Line A
-   
-   Line B
+1. > Line A  
+   > Line B
 
 * * *
 
@@ -118,6 +116,8 @@ text between
 
 <!--THE END-->
 
+
+
 - List 7
 
 * * *
@@ -136,6 +136,13 @@ text between
 
 - Start Line
 
+
+
+
+
+
+
+
   End Line
 
 <!--------------------------------------

diff --git a/plugin/commonmark/testdata/GoldenFiles/metadata.out.md b/plugin/commonmark/testdata/GoldenFiles/metadata.out.md
@@ -24,6 +24,10 @@ A &amp; B
 \[foo]: /url "not a reference"  
 &amp;ouml; not a character entity
 
-Start Line
-
+Start Line  
+
+
+
+
+
 End Line