You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If $normalize-vertical-rhythm is set to false manually we should be able to change the value of variable without the $normalize-vertical-rhythm being overridden here:
// If we've customized any font variables, we'll need extra properties.
@if $base-line-height != 24px
or $base-unit != 'em'
or $h2-font-size != 1.5 * $base-font-size
or $h3-font-size != 1.17 * $base-font-size
or $h4-font-size != 1 * $base-font-size
or $h5-font-size != 0.83 * $base-font-size
or $h6-font-size != 0.67 * $base-font-size {
$normalize-vertical-rhythm: true !global;
}
The logic should first detect if $normalize-vertical-rhythm was set by the user and only overwrite it if not. A better default value, therefore, would be null. You could then check against null in the above and only force to true if so. If false, then honour the users choice and don't output.
The checks for @if $normalize-vertical-rhythm { would all still work as intended.
The text was updated successfully, but these errors were encountered:
If
$normalize-vertical-rhythm
is set to false manually we should be able to change the value of variable without the$normalize-vertical-rhythm
being overridden here:The logic should first detect if
$normalize-vertical-rhythm
was set by the user and only overwrite it if not. A better default value, therefore, would benull
. You could then check against null in the above and only force to true if so. If false, then honour the users choice and don't output.The checks for
@if $normalize-vertical-rhythm {
would all still work as intended.The text was updated successfully, but these errors were encountered: