Replace deprecated slash division by math.div() to prepare for Dart Sass 2.0.0 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnAlbin can we get this merged in and published. |
|
for anyone desperate I just republished this as @biere/normalize-scss including this fix. not intended as a fork, only to temporarily unblock myself. |
|
It has been almost 3 years, a fix is available, however not merged. Oh.. the problem of open source ecosystem, not having enough time in a day to look after packages we no longer use. |
|
@JohnAlbin would you mind merging this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Dart Sass 1.33.0 deprecation warnings regarding using slash for divisions are printed to the console when using normalize-scss in the same project. In order to prepare for the Dart Sass 2.0.0 release and to make sure that normalize-scss can be used in the future, the affected code parts have to be updated.
A blog post on the topic can be found here: https://sass-lang.com/documentation/breaking-changes/slash-div.
The issue has already been reported in the main repository here: #148.
This PR now aims to resolve that issue.