update dependencies #1
Conversation
kontrollanten
commented
Dec 22, 2024
•
kontrollanten
commented
- Update dependencies
kontrollanten
force-pushed
the
update-deps
branch
from
52c7c19 to
66e49b8
Compare
There was a problem hiding this comment.
Why do you change the stylelintrc filetype ? Is there a good reason?
Using a JS file allows comment (if needed). That could help if the configuration become more complexe one day.
| "build:server": "npx tsc --build server/tsconfig.json", | ||
| "build:client": "node ./scripts/build.js", | ||
| "build:server": "npx tsc --build tsconfig.json", | ||
| "build:client": "node ./scripts/build.mjs", |
There was a problem hiding this comment.
Why have you changed the file type to a mjs?
This is a script, not a module. Is there a good reason that i missed?
| "build:styles": "npx sass --no-source-map assets:dist/assets", | ||
| "build": "npm-run-all -s clean check:client:tsc -p build:server build:client build:styles", | ||
| "lint:script": "npx eslint --ext .ts --ext .js .", | ||
| "lint:script": "eslint", |
There was a problem hiding this comment.
Why do you removed the npx call?
Using npx ensure that it is using the eslint version in the node_modules directory, and not any globally installed eslint (which could cause some issue if the version is not matching).
| "esbuild": "^0.14.36", | ||
| "eslint": "^8.21.0", | ||
| "eslint-config-standard-with-typescript": "^22.0.0", | ||
| "@peertube/peertube-types": "^7.0.0", |
There was a problem hiding this comment.
There was a good reason to let "@peertube/peertube-types": "^4.2.2",: in the engine section, I mention that this plugin is compatible with "peertube": ">=4.2.0".
So we must use the Peertube 4.2.x types, to be sure to not use features that are not avaible.
This is explained in the README.
| "eslint": "^8.21.0", | ||
| "eslint-config-standard-with-typescript": "^22.0.0", | ||
| "@peertube/peertube-types": "^7.0.0", | ||
| "@tsconfig/node18": "^18.2.4", |
There was a problem hiding this comment.
The tsconfig/nodexx dependency should match the node version supported by the supported Peertube version.
This template is meant for Peertube >= 4.2.0, so it should be Node16.
| @@ -1,10 +1,13 @@ | |||
| import type { RegisterServerOptions } from '@peertube/peertube-types' | |||
|
|
|||
| async function register ({ peertubeHelpers }: RegisterServerOptions): Promise<void> { | |||
| await Promise.resolve() | |||
| peertubeHelpers.logger.info('Hello world') | ||
| } | ||
|
|
||
| async function unregister (): Promise<void> {} | ||
| async function unregister (): Promise<void> { | ||
| await Promise.resolve() |
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "extends": "@tsconfig/node16/tsconfig.json", | |||
| "extends": "@tsconfig/node18/tsconfig.json", | |||
There was a problem hiding this comment.
See previous comment. Should be related to the supported Peertube version.
| "compilerOptions": { | ||
| "moduleResolution": "node", // Tell tsc to look in node_modules for modules | ||
| "moduleResolution": "node16", // Tell tsc to look in node_modules for modules |
| "outDir": "./dist/", | ||
| "paths": {}, | ||
| "allowJs": true | ||
| }, | ||
| "include": [ | ||
| "./**/*" | ||
| "./server/**/*", | ||
| "**/*.mjs" | ||
| ], | ||
| "exclude": [] | ||
| "exclude": [ | ||
| "./client" | ||
| ] |
There was a problem hiding this comment.
Why to you moved the server tsconfig file?
Server and Client configuration were separate. Moving the server tsconfig in the root directory adds confusion (IMHO).
