Merge pull request #2 from JohnodonCode/dev

actually make things optimized. oops
JohnodonCode · Jul 22, 2021 · cfcf3ef · cfcf3ef
2 parents 360e55b + 2dcb312
commit cfcf3ef
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/betterperms/Commands/setconfig/FriendlyFire.cs b/betterperms/Commands/setconfig/FriendlyFire.cs
@@ -13,7 +13,7 @@ class FriendlyFire : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("friendlyfire", sender))
+            if (Methods.CheckSCPerms("friendlyfire", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Commands/setconfig/HumanGrenadeMultiplier.cs b/betterperms/Commands/setconfig/HumanGrenadeMultiplier.cs
@@ -14,7 +14,7 @@ class HumanGrenadeMultiplier : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("humangrenademultiplier", sender))
+            if (Methods.CheckSCPerms("humangrenademultiplier", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Commands/setconfig/PDRefreshExit.cs b/betterperms/Commands/setconfig/PDRefreshExit.cs
@@ -14,7 +14,7 @@ class PDRefreshExit : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("pdrefreshexit", sender))
+            if (Methods.CheckSCPerms("pdrefreshexit", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Commands/setconfig/PlayerListTitle.cs b/betterperms/Commands/setconfig/PlayerListTitle.cs
@@ -14,7 +14,7 @@ class PlayerListTitle : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("playerlisttitle", sender))
+            if (Methods.CheckSCPerms("playerlisttitle", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Commands/setconfig/ScpGrenadeMultiplier.cs b/betterperms/Commands/setconfig/ScpGrenadeMultiplier.cs
@@ -14,7 +14,7 @@ class ScpGrenadeMultiplier : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("scpgrenademultiplier", sender))
+            if (Methods.CheckSCPerms("scpgrenademultiplier", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Commands/setconfig/SpawnProtectDisable.cs b/betterperms/Commands/setconfig/SpawnProtectDisable.cs
@@ -13,7 +13,7 @@ class SpawnProtectDisable : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("spawnprotectdisable", sender))
+            if (Methods.CheckSCPerms("spawnprotectdisable", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Commands/setconfig/SpawnProtectTime.cs b/betterperms/Commands/setconfig/SpawnProtectTime.cs
@@ -13,7 +13,7 @@ class SpawnProtectTime : ICommand
 
         public bool Execute(ArraySegment<string> arguments, ICommandSender sender, out string response)
         {
-            if (!new Methods().CheckSCPerms("spawnprotecttime", sender))
+            if (Methods.CheckSCPerms("spawnprotecttime", sender))
             {
                 response = "You do not have permission to use this command.";
                 return false;

diff --git a/betterperms/Methods.cs b/betterperms/Methods.cs
@@ -6,7 +6,7 @@ namespace BetterPerms
     class Methods
     {
         //command permissions
-        internal bool CheckSCPerms(string node, ICommandSender sender)
+        internal static bool CheckSCPerms(string node, ICommandSender sender)
         {
             if(!sender.CheckPermission($"{Plugin.Instance.Config.ScBasePermission}.{node}") && !sender.CheckPermission(Plugin.Instance.Config.ScBasePermission) && !sender.CheckPermission(PlayerPermissions.ServerConfigs))
             {