Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding problems with gutter #649

Closed
nihlete opened this issue Aug 2, 2019 · 5 comments
Closed

Encoding problems with gutter #649

nihlete opened this issue Aug 2, 2019 · 5 comments

Comments

@nihlete
Copy link

nihlete commented Aug 2, 2019

  • VSCode Version: 1.36.1
  • OS Version: Microsoft Windows 7 [Version 6.1.7601]
  • Extension Version: 1.54.4
  • System Language: Russian, windows-1251
  • SVN Version: TotroiseSvn 1.12

Issue

Gutter shows, that there is some unsaved editions on characters specific to windows-1251 encoding.

I've tryed to use different variants of settings "files.autoGuessEncoding" and "svn.default.encoding" with true/false and none/windows1251/windows-1251/cp1251 respectfully.

There is some similar issues back in time: #594, #526, #483, #9.

Steps to Reproduce

  1. Commit to repo file with windows-1251 encoding (and specific characters)
  2. Open VScode

SVN Output

[tempRepoWorkingCopy]$ svn info --xml e:\Projects\tempRepoWorkingCopy\iddqd.cpp
[tempRepoWorkingCopy]$ svn cat iddqd.cpp

Screenshots

Gutter
extentions

User settings

{
    "editor.fontSize": 12,
    "editor.minimap.enabled": false,
    "editor.fontLigatures": true,
    "editor.rulers": [
        120
    ],
    "window.zoomLevel": 0,
    "terminal.integrated.shell.windows": "C:\\Windows\\system32\\cmd.exe",
    "window.restoreWindows": "none",
    "files.associations": {
        "*.cu": "cpp"
    },
    
    "C_Cpp.default.cppStandard": "c++14",
    "C_Cpp.default.intelliSenseMode": "clang-x64",
    "diffEditor.ignoreTrimWhitespace": true,
    "editor.fontFamily": "'Fira Code', Consolas, 'Courier New', monospace",
    "editor.renderWhitespace": "none",
    "files.autoGuessEncoding": false,
    "git.autofetch": true,
    "http.proxy": "http://user:password@server.domain:port",
    "svn.default.encoding": "windows-1251",
    "svn.diff.withHead": false,
    "svn.enableProposedApi": "none",
    "workbench.colorTheme": "Solarized Dark",
    "workbench.editor.tabSizing": "shrink",
    "C_Cpp.default.cStandard": "c99"
}

Repo and workspace example:
example.zip

@JohnstonCode
Copy link
Owner

Can you try

"files.encoding": "windows1251",
"files.autoGuessEncoding": false

and delete "svn.default.encoding"

@nihlete
Copy link
Author

nihlete commented Aug 2, 2019

With your tweaks it work good.

@JohnstonCode
Copy link
Owner

Glad its working for you now. Can i close the issue?

@nihlete
Copy link
Author

nihlete commented Aug 2, 2019

It could be good to have sync between "files.autoGuessEncoding": true and SVN stuff,
but I'm fine with this workaround.

@JohnstonCode
Copy link
Owner

Yeah it would be nice but encoding is an absolute mine field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants