Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode after version 1.47.4 #526

Closed
GabrielBFern opened this issue Mar 25, 2019 · 7 comments
Closed

Encode after version 1.47.4 #526

GabrielBFern opened this issue Mar 25, 2019 · 7 comments
Assignees
Labels

Comments

@GabrielBFern
Copy link

GabrielBFern commented Mar 25, 2019

  • VSCode Version: 1.30.2
  • OS Version: Windows_NT x64 10.0.17763
  • Extension Version: 1.47.5
  • System Language: Português (Brasil)
  • SVN Version: 1.9.5-SlikSvn

Issue

Show changes in non-modified files after update to extension version 1.47.4. If I use version 1.47.3 works fine.

My config in settings.json:
"svn.default.encoding": "windows-1252",
"svn.multipleFolders.enabled": true

Steps to Reproduce

  1. Open a file with encode windows 1252
  2. The gutter to the left of the editor will show changes in special characters (Example: ç, é, á, ã )

SVN Output

Using svn "1.9.5-SlikSvn" from "f:\xxx\svn\svn.exe"
[fon]$ svn info --xml f:\xxx\wc\des\barbosa\fon\TSTBAR.CBL
[rwd]$ svn info --xml
[fon]$ svn cat f:\xxx\wc\des\barbosa\fon\TSTBAR.CBL
[mod]$ svn stat --xml --no-ignore --ignore-externals --show-updates
[rwd]$ svn stat --xml --no-ignore --ignore-externals --show-updates

Screenshots

image

@edgardmessias
Copy link
Contributor

@GabrielBFern, you can check your files.encoding?

Test with: "files.encoding": "windows-1252"

@GabrielBFern
Copy link
Author

With "files.encoding" solve the problem, but when I use "files.enconding" per language doesn't work (I use different encoding with each language).
Example:
"[COBOL]": {
"files.encoding": "windows-1252",
}, (Doens't work)
"files.encoding": "windows-1252", (work)

And "files.encoding" say that "windows-1252" is not a valid option and "windows1252" is the correct one, but works with "windows-1252".

@mayerui
Copy link

mayerui commented May 31, 2019

I feel confused too .
图片

@edgardmessias edgardmessias self-assigned this May 31, 2019
edgardmessias added a commit to edgardmessias/svn-scm that referenced this issue May 31, 2019
@edgardmessias
Copy link
Contributor

@GabrielBFern, @mayerui , make a test with: svn-scm-1.50.0.vsix.zip

@mayerui
Copy link

mayerui commented Jun 1, 2019

@GabrielBFern, @mayerui , make a test with: svn-scm-1.50.0.vsix.zip

Thanks for your attention. But there is no changes. May I provide more infomation: VSCode detect my files' encoding is "GB 2312", and every trouble is about Chinese words. Hope my reply helpful.
捕获
捕获2

@edgardmessias
Copy link
Contributor

Try set files.enconding with correct value and filés.autoGuestEncoding to false.

JohnstonCode added a commit that referenced this issue Jun 1, 2019
## [1.50.1](v1.50.0...v1.50.1) (2019-06-01)

### Bug Fixes

* Fixed encoding detection for gutter (close [#526](#526)) ([#590](#590)) ([22e40f9](22e40f9))
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.50.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants