fix: Fix for missing steps in the UI

This is a partial revert of argoproj#12130 and fixes argoproj#12165

Offered as an alternative to a full revert.

Signed-off-by: Alan Clucas <alan@clucas.org>

workflow/controller/dag.go

@@ -351,6 +351,11 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
 		return node, err
 	}
 	if outputs != nil {
+		node, err = woc.wf.GetNodeByName(nodeName)
+		if err != nil {
+			woc.log.Errorf("unable to get node by name for %s", nodeName)
+			return nil, err
+		}
 		node.Outputs = outputs
 		woc.wf.Status.Nodes.Set(node.ID, *node)
 	}

workflow/controller/steps.go

@@ -172,6 +172,10 @@ func (woc *wfOperationCtx) executeSteps(ctx context.Context, nodeName string, tm
 	}
 
 	if outputs != nil {
+		node, err := woc.wf.GetNodeByName(nodeName)
+		if err != nil {
+			return nil, err
+		}
 		node.Outputs = outputs
 		woc.addOutputsToGlobalScope(node.Outputs)
 		woc.wf.Status.Nodes.Set(node.ID, *node)