Fix: Ensure contents are not clipped on mobile browsers #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumzledz
force-pushed
the
fix/3352-prefer-dvh-over-vh
branch
6 times, most recently
from
b40f368 to
8daa081
Compare
rumzledz
force-pushed
the
fix/3352-prefer-dvh-over-vh
branch
from
8daa081 to
6b3cb90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically 100vh is problematic on browsers like Safari mobile due to the presence of the address bar. 100vh ignores Safari mobile's URL bar whereas 100dvh takes that into account and removes its height from the overall screen estate calculation, which is suitable for our use case:
Testing
Note
The best way to test this is with the iOS simulator
Resolves #3352