Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use subscriptions to automatically show Advanced Payment actions on the Actions Table #3976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Dec 18, 2024

Description

This PR addresses an issue where Advanced Payments are not automatically being shown on the Actions table.

At first, I tried to simply subscribe to action creation. But I found that this was not the best solution since the action's metadata isn't yet ready, which causes our activity table to use fallback action descriptions which is not ideal behaviour.

So instead, I'm subscription to an action's metadata creation which works perfectly ✨

AP staking demo

Testing

Note

If you're not seeing the advanced payment on the actions table, first verify that you're not able to see any new action types. If you're unable to see new actions then something probably broke in your environment.

  1. Bring up the Advanced Payment form
  2. Fill in all required fields
  3. Submit the form
  4. Verify that the Latest Activity table is:
  • automatically updated
  • using the correct title you've used for your action

Resolves #3581

@rumzledz rumzledz self-assigned this Dec 18, 2024
@rumzledz rumzledz marked this pull request as ready for review December 18, 2024 16:40
@rumzledz rumzledz requested a review from a team as a code owner December 18, 2024 16:40
@rumzledz rumzledz changed the title Fix: Use subscriptions for auto refetching actions Fix: Use subscriptions to automatically show Advanced Payment actions on the Actions Table Dec 18, 2024
@rumzledz rumzledz force-pushed the fix/3581-automatically-update-activity-table branch from c9a0695 to 280a9f6 Compare December 18, 2024 18:16
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nice solution to this issue @rumzledz 💯

Screen.Recording.2024-12-19.at.10.15.38.mov

Works like a charm ✨

Copy link
Contributor

@Nortsova Nortsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix ✨ Activity table updated successfully 🎉

Dec-20-2024 15-22-46

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and slick solution 😎

subscription-adv-pay-2024-12-23_15.16.49.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA: Advanced Payments not showing without manual refresh in activity feed
4 participants