Feat/3537 arbitrary via multi sig

[Nortsova]

Description

This issue covers the multi-sig flow of creating arbitrary transaction.

New saga needs to be added that should accept a target contract address and a list of arbitrary transactions, consisting of function name and a list of arguments. It should create a multi-sig motion to call makeArbitraryTransactions on the Colony contract.

Note

Please Review block-ingestor PR too - JoinColony/block-ingestor#306

Testing

Step 1. Install Multi-Sig extension http://localhost:9091/planex/extensions/MultisigPermissions
Step 2. Give leela and amy owner Multi-Sig roles:

Step 3. Create Custom transaction action ("Manage Colony" -> "Custom transactions")

Step 4. Create transaction with the following (or you can use beautiful approach of custom contract that Jakub described here: #3966 )
Contract address: 0xeF841fe1611ce41bFCf0265097EFaf50486F5111
ABI:

[{"type":"constructor","payable":false,"inputs":[{"type":"string","name":"_name"},{"type":"string","name":"_symbol"},{"type":"uint8","name":"_decimals"}]},{"type":"event","anonymous":false,"name":"Approval","inputs":[{"type":"address","name":"src","indexed":true},{"type":"address","name":"guy","indexed":true},{"type":"uint256","name":"wad","indexed":false}]},{"type":"event","anonymous":false,"name":"Burn","inputs":[{"type":"address","name":"guy","indexed":true},{"type":"uint256","name":"wad","indexed":false}]},{"type":"event","anonymous":false,"name":"LogSetAuthority","inputs":[{"type":"address","name":"authority","indexed":true}]},{"type":"event","anonymous":false,"name":"LogSetOwner","inputs":[{"type":"address","name":"owner","indexed":true}]},{"type":"event","anonymous":false,"name":"MetaTransactionExecuted","inputs":[{"type":"address","name":"user","indexed":false},{"type":"address","name":"relayerAddress","indexed":false},{"type":"bytes","name":"functionSignature","indexed":false}]},{"type":"event","anonymous":false,"name":"Mint","inputs":[{"type":"address","name":"guy","indexed":true},{"type":"uint256","name":"wad","indexed":false}]},{"type":"event","anonymous":false,"name":"Transfer","inputs":[{"type":"address","name":"src","indexed":true},{"type":"address","name":"dst","indexed":true},{"type":"uint256","name":"wad","indexed":false}]},{"type":"function","name":"DOMAIN_SEPARATOR","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"bytes32"}]},{"type":"function","name":"PERMIT_TYPEHASH","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"bytes32"}]},{"type":"function","name":"allowance","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"src"},{"type":"address","name":"guy"}],"outputs":[{"type":"uint256"}]},{"type":"function","name":"approve","constant":false,"payable":false,"inputs":[{"type":"address","name":"guy"},{"type":"uint256","name":"wad"}],"outputs":[{"type":"bool"}]},{"type":"function","name":"authority","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"address"}]},{"type":"function","name":"balanceOf","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"src"}],"outputs":[{"type":"uint256"}]},{"type":"function","name":"burn","constant":false,"payable":false,"inputs":[{"type":"uint256","name":"wad"}],"outputs":[]},{"type":"function","name":"burn","constant":false,"payable":false,"inputs":[{"type":"address","name":"guy"},{"type":"uint256","name":"wad"}],"outputs":[]},{"type":"function","name":"decimals","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"uint8"}]},{"type":"function","name":"executeMetaTransaction","constant":false,"stateMutability":"payable","payable":true,"inputs":[{"type":"address","name":"_user"},{"type":"bytes","name":"_payload"},{"type":"bytes32","name":"_sigR"},{"type":"bytes32","name":"_sigS"},{"type":"uint8","name":"_sigV"}],"outputs":[{"type":"bytes"}]},{"type":"function","name":"getMetatransactionNonce","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"_user"}],"outputs":[{"type":"uint256","name":"nonce"}]},{"type":"function","name":"locked","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"bool"}]},{"type":"function","name":"mint","constant":false,"payable":false,"inputs":[{"type":"address","name":"guy"},{"type":"uint256","name":"wad"}],"outputs":[]},{"type":"function","name":"mint","constant":false,"payable":false,"inputs":[{"type":"uint256","name":"wad"}],"outputs":[]},{"type":"function","name":"name","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"string"}]},{"type":"function","name":"nonces","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"_user"}],"outputs":[{"type":"uint256","name":"nonce"}]},{"type":"function","name":"owner","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"address"}]},{"type":"function","name":"permit","constant":false,"payable":false,"inputs":[{"type":"address","name":"owner"},{"type":"address","name":"spender"},{"type":"uint256","name":"value"},{"type":"uint256","name":"deadline"},{"type":"uint8","name":"v"},{"type":"bytes32","name":"r"},{"type":"bytes32","name":"s"}],"outputs":[]},{"type":"function","name":"setAuthority","constant":false,"payable":false,"inputs":[{"type":"address","name":"authority_"}],"outputs":[]},{"type":"function","name":"setOwner","constant":false,"payable":false,"inputs":[{"type":"address","name":"owner_"}],"outputs":[]},{"type":"function","name":"symbol","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"string"}]},{"type":"function","name":"totalSupply","constant":true,"stateMutability":"view","payable":false,"inputs":[],"outputs":[{"type":"uint256"}]},{"type":"function","name":"transfer","constant":false,"payable":false,"inputs":[{"type":"address","name":"dst"},{"type":"uint256","name":"wad"}],"outputs":[{"type":"bool"}]},{"type":"function","name":"transferFrom","constant":false,"payable":false,"inputs":[{"type":"address","name":"src"},{"type":"address","name":"dst"},{"type":"uint256","name":"wad"}],"outputs":[{"type":"bool"}]},{"type":"function","name":"unlock","constant":false,"payable":false,"inputs":[],"outputs":[]},{"type":"function","name":"verify","constant":true,"stateMutability":"view","payable":false,"inputs":[{"type":"address","name":"_user"},{"type":"uint256","name":"_nonce"},{"type":"uint256","name":"_chainId"},{"type":"bytes","name":"_payload"},{"type":"bytes32","name":"_sigR"},{"type":"bytes32","name":"_sigS"},{"type":"uint8","name":"_sigV"}],"outputs":[{"type":"bool"}]}]

Step 5. Select Decision Method: Multi-Sig
Step 6. Submit form
Step 7. Ensure that Multi-Sig motion was created:

Step 8. Login as amy from incognito window and approve motion
Step 9. Finalize it
Step 10. Verify that you can see Incoming funds (that was minted because of the Contract call)

Step 11. Repeat Step 3 - Step 7.
Step 12. Remove your vote and reject motion
Step 13. Verify that there is no new income funds (means no Contract was called)

Contributes to #3537

[mmioana]

Impressive work on adding Custom transactions via Multi-sig @Nortsova 🥇

Installed the Multi-sig extension

Gave leela and amy Owner permissions in General for Multi-sig actions

Created a Custom transactions multi-sig motion

Approved as leela

And as amy

And could see the incoming funds after this motion was finalised

Then created another Custom transactions via multi-sig that I have rejected

And nothing changed on the incoming funds page

Nice work!!!

[davecreaser]

Nice work @Nortsova! All the code is looking good and it looks to be working as expected:

After installing the extension and giving permissions I could make the action, vote and finalize:

And there were incoming funds: (a tiny amount 🤣)

And cancelling also worked, without new incoming funds appearing:

[bassgeta]

Really nice and simple 👌
Form looking all good ✔️

Removing a vote works ✔️

Reapproving works ✔️

Approving as amy works ✔️

And finalization also goes through 😎

However, I just wanted to raise a question here

test is the multi-sig motion and it doesn't have the correct description, should this be added?

is Generic action we don't have information about for the actual contract call OK, or should it be something else?

Will preliminarily request changes, and if it's not in scope of this isssue, I'll just approve.

Overall, great job 💪

[Nortsova]

Nice catch, @bassgeta . Thank you for your help. Fix for Generic action is here now 🙌

[bassgeta]

Everything still works, and the actions aren't duplicated anymore, there's just one action in the list!

[jakubcolony]

Looks great, well done @Nortsova 👍

@bassgeta regarding the action metadata in the activity feed, this will be handled in a separate issue - #3538.

The base branch was changed.

[mmioana]

Re-approving 👍

[davecreaser]

Still all good with me after a quick retest 🚀

Reapproving!