Feat: Add manage supported chain action #4006
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Add manage supported chain action
Description
Manage supported chains
✨ action, including the action and completed action views for both adding/removing support ( aka deploying a proxy colony and disabling it ) and the saga for disabling the proxy colony.Block ingestor PR
Testing
TODO: Let's test we can actually deploy a proxy colony and then disable it.
Important
Make sure you have the
POSTHOG_KEY
andPOSTHOG_HOST
set. If you don't have the values, please don't hesitate to contact me.Note
Given for the moment we only span 2 more proxy colonies, only 2 chain options are enabled.
Step 1. Please start a fresh dev env
npm run dev
Step 2. Create some data
node scripts/create-data.js
Step 3. Please create a new colony by running
node scripts/create-colony-url.js
and complete the colony creationStep 4. Let's first check the feature flag works accordingly. Click
Manage colony
Step 5. You should see the
Manage supported chains
brand new actionStep 6. At line
48
insrc/context/FeatureFlagsContext/FeatureFlagsContextProvider.tsx
, add these linesStep 7. Check the sidebar again. You should no longer see the
Manage supported chains
actionStep 8. Revert the changes
Step 9. Let's create a
Manage supported chains
action. SelectAdd supported chain
for add/remove field andEthereum
as the chainStep 9. Add other missing fields and complete action.
This will fail for the moment and the
404
will be shown in the completed action view due to thecolonyId
being not properly set, thus causing the query fetching an action to error out.Step 10. Let's manually adjust this. Run the following mutation
You can find the tx hash either in the console or in the search params
Step 11. Refresh the page and if you haven't close the action sidebar, you should see the view. Otherwise you can find the action in the activity table or just manually set the
?txHash=<TX_HASH_HERE>
search paramStep 12. Now please create another
Manage supported chains
action.Step 13. Select the
Add chain support
for theAdd/remove
andEthereum
should no longer be in the chain selectStep 13. Now select
Remove chain support
for theAdd/remove
field.Ethereum
should be the only available option for the chain selectStep 14. Fill the missing fields and create the action.
Screen.Recording.2024-12-27.at.12.08.57.mov
Diffs
New stuff ✨
disableProxyColony
sagaManage supported chains
actionManage supported chains
actionTODO
colonyId
upon deploying aproxy colony
needs to be solved in order to properly solve thisResolves #3410
Resolves #3411
Resolves #3412
Resolves #3413
Resolves #3414