Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand agreement desc by default #4010

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

CzarekDryl
Copy link
Contributor

Description

  • Description field for the “Create agreement” action type is expanded by default when in the completed state
image

Testing

  • Install Reputation Weighted (Lazy Consensus method) extension
  • Create a new agreement
  • Check if description field is expanded by default

Resolves #3991

@CzarekDryl CzarekDryl self-assigned this Dec 27, 2024
@CzarekDryl CzarekDryl requested a review from a team as a code owner December 27, 2024 12:09
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this issue @CzarekDryl 🙌

Upon creating an agreement the description field is expanded. The Show less still works as expected

Screen.Recording.2024-12-30.at.07.09.56.mov

Nice work! 💯

Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CzarekDryl Nice and easy, works great, good addition. Thank you!!

description-expanded

@CzarekDryl CzarekDryl merged commit be0c4fc into master Jan 2, 2025
2 checks passed
@CzarekDryl CzarekDryl deleted the feat/16215340-agreement-description branch January 2, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACTIONS] Show expanded descriptions within agreement actions by default
3 participants