Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension settings loading states #4015

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

davecreaser
Copy link
Contributor

Description

Testing

  • Go to any extension page
  • Install the extension
  • Change the extension settings (and save)
  • Enable the extension
  • Deprecate the extension
  • Uninstall the extension
  • At each stage, check that you cannot do another extension management action, and that any other buttons for extension management from the list above are disabled if they are shown. The video below may help:
Screen.Recording.2024-12-30.at.13.48.27.mov

Diffs

Changes 🏗

  • Update the extension details page utils to make use of a loading state context, and have the buttons be disabled when it's active

Resolves #3577

@davecreaser davecreaser requested a review from a team as a code owner December 30, 2024 13:59
@davecreaser davecreaser self-assigned this Dec 30, 2024
Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I have a feeling this context is gonna see more use, which is completely legit since we have quite some edge cases on this page.
So nice job sorting this out 😎 I've initially thought it may be a perfect time to whip out transitions just so we start using them, but I don't think it's applicable here at all so ignore my rambles :D

I've tried clicking and breaking everything, it didn't even budge, nice one 💪

extension-management-2025-01-06_10.26.19.mp4

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work on this one @davecreaser 💯

Once an action is performed on the extension, the other actions are disabled 🙅

Screen.Recording.2025-01-07.at.11.12.05.mov

Copy link
Contributor

@Nortsova Nortsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this 👍

I like this approach, I am pretty sure we can use this hook flag all over the app. 🙌

extension-disabled

@davecreaser davecreaser merged commit 850edf8 into master Jan 9, 2025
2 checks passed
@davecreaser davecreaser deleted the fix/#3577-extension-uninstall-enable-button branch January 9, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension Enable button should be disabled whilst uninstall transaction processes
4 participants