Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add back button to action sidebar #4016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add back button to action sidebar #4016

wants to merge 3 commits into from

Conversation

CzarekDryl
Copy link
Contributor

@CzarekDryl CzarekDryl commented Dec 30, 2024 •
edited
Loading

Description

  • Added back button to action sidebar
image

Testing

  1. Back Arrow:
  • Appears only after an action is selected.
  • Navigates to the relevant action list view category.
  • Not visible on the main action list view.
  1. Completed Actions:
  • Navigates to the relevant list view category.
  1. Browser Back Button:
  • Returns to the previous action transaction if clicked after navigating away.
  1. Hover State:
  • On desktop, matches other action header icons and uses the blue-400 color.

Resolves #3973

@CzarekDryl CzarekDryl self-assigned this Dec 30, 2024
@CzarekDryl CzarekDryl requested a review from a team as a code owner December 30, 2024 14:32
@CzarekDryl CzarekDryl marked this pull request as draft December 30, 2024 14:47
@CzarekDryl CzarekDryl marked this pull request as ready for review December 31, 2024 08:27
arrenv
arrenv requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CzarekDryl Nice work, it works great.

The only thing not working as expected is the browser back button requires two clicks before the sidepanel opens up.

All back arrow buttons working as of spec:

working-back-button

@CzarekDryl
Copy link
Contributor Author

@arrenv Browser back button is working fine now

Screen.Recording.2025-01-03.at.11.56.28.mov

@CzarekDryl CzarekDryl requested a review from arrenv January 3, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrenv arrenv Awaiting requested review from arrenv

Requested changes must be addressed to merge this pull request.

Assignees

@CzarekDryl CzarekDryl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ACTIONS] Add back button to action header
2 participants
@CzarekDryl @arrenv