Fix bookkeeping and querying around mining stakes #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two sort-of-related updates:
miningStakeson colonyNetwork. This PR now removes it from both.getObligationon tokenLocking (which is why the above error wasn't caught by our tests), looking at the obligation they had to the colonyNetwork contract in CLNY tokens. While these numbers have to be the same currently, there's no guarantee of that being the case in the future. This change future-proofs us should a new feature change this.This PR is based against
master, and I would intend to do a release and deployment once merged.