Replace DEPRECATED with @deprecated #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmanie
force-pushed
the
maint/replace-deprecated-natspec-tag
branch
from
a2436e2 to
dd974d5
Compare
|
Ah, I see, okay. |
|
What does that mean for this PR? |
|
That we likely have to use instead. Sorry I didn't get to adjusting that. |
chmanie
force-pushed
the
maint/replace-deprecated-natspec-tag
branch
from
6c710f3 to
c545442
Compare
|
So the issue here is that you've changed VotingReputation. There are no functional changes, but the script isn't bright enough to realise that and thinks it should have its version bumped. I'm not really sure what to do about this, I'm going to be fairly resistant to changing that script. |
chmanie
force-pushed
the
maint/replace-deprecated-natspec-tag
branch
from
c545442 to
e8e4060
Compare
area
force-pushed
the
maint/replace-deprecated-natspec-tag
branch
from
e8e4060 to
7eb39f2
Compare
area
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1035
I also took the liberty to fix some of the NatSpec warnings we got when running build:docs.