-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions contracts to docgen #1059
Conversation
dc6b8e4
to
1c39ecf
Compare
142e5d5
to
0fb311b
Compare
458b3ad
to
b339e52
Compare
89c6335
to
d04e93e
Compare
3882ff4
to
e3f0ab6
Compare
1f7c833
to
0bea150
Compare
5208618
to
fd5949e
Compare
7d0984e
to
a0b1de4
Compare
a0b1de4
to
9166810
Compare
Okay, so the changes I've done here:
Broadly speaking I'm now fine with the state of this, but I'd like @kronosapiens's input on the versioning script and if he thinks it could be improved / scenarios that it misses. |
mv build build-$LATEST_RELEASE | ||
|
||
git checkout yarn.lock | ||
rm package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any handling if/when we move into a world where we're dealing only with the npm versions of the repo?
This PR adds the extension contracts to the
docgen
script. As they are not pureInterface
contracts, some adjustments to the docgen script were necessary (inspection of nodes to be actual method nodes and checking of their visibility).Note: the docgen script will now fail (exit with 1) if the docs couldn't be properly parsed in one or more instances (before they were just logged as warnings). Because we try to build the docs on CI as well now, this will make the CI tests fail if the docs can't be built.
Furthermore I fixed the issues raised in #1056 and #1057.
Closes #1056.
Closes #1057.
Closes #1036.