-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tasks and Payments #1150
Conversation
26a30ad
to
8637e58
Compare
5ff9065
to
72675f5
Compare
dd94d84
to
8765f25
Compare
8765f25
to
0998015
Compare
d48aa7a
to
b198c73
Compare
b844200
to
81cbc51
Compare
81cbc51
to
0ad1678
Compare
Out of a meeting I've just had with Arren/Jack: OneTxPayment should work even if there is a non-zero global claim delay for expenditures. |
5b58225
to
03ea933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of, in finishUpgrade
of OneTxPayment
:
- Check if we (the extension) has root permission in the colony.
- If not, no further actions and return
- If it does, award itself arbitration permission in root domain
This obviously doesn't capture all scenarios, but will mean that the front-end team don't have to worry about handling the adding of the permission on upgrade, based on how the extension is currently used.
@area works for me. Do you want me to add it or you? |
This doesn't actually work, OneTxPayment is only awarded Funding and Administration currently, so I'll remove the commit. |
34afb91
to
03ea933
Compare
03ea933
to
9775819
Compare
Closes #1126
Removes Tasks and Payments from the core contracts. Specifically:
ColonyTask.sol
andColonyPayments.sol
and removes all references to them from the rest of the contractsFor simplicity, the tests have been left otherwise untouched, meaning that we still give out reputation in the same way as we did when we used Tasks (i.e. three recipients, penalties, etc).
A bit unrelated, but this PR also does the following:
globalClaimDelay
to 0