-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent StreamingPayment uninstallation if pending streams remain #1251
Conversation
1a54bad
to
a17d2b7
Compare
f75fde4
to
d63d67b
Compare
a17d2b7
to
9fddd41
Compare
53b7bbf
to
58d4d6e
Compare
fc1cdaa
to
a78f8c2
Compare
1929430
to
78ab0ee
Compare
c0ee585
to
5a5ae87
Compare
78ab0ee
to
273ee11
Compare
5a5ae87
to
89fe76c
Compare
273ee11
to
943a097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of new code just to implement an uninstall check, but so it goes I guess
943a097
to
d168916
Compare
295f2e2
to
de82deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mention that changing the interval is necessary to avoid rounding errors, but realistically what are the errors we're talking about? A few wei? I would be in favor of going the opposite direction and hard-coding the interval as 24 hours. We can provide a UI which converts different intervals (hour, week month, etc) if needed.
de82deb
to
efb313a
Compare
If tokens don't have, or have set In terms of a hard-coded interval, even ignore editing existing streams: if we had it at 24 hours, we couldn't e.g. pay out 1 token that had |
d53bb6c
to
eac32f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
eac32f2
to
08d6b3a
Compare
The main feature here is to prevent uninstallation of the extension in the event that there are some streaming payments unclaimed. It also: