Only have normalized storage layouts in repository #1289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1258 I said
I am now of the opinion I was wrong, and longer believe that distinction is worthwhile at the cost of having huge diffs in PRs (such as in #1144, where the diff for a large feature is still dominated by non-meaningful changes in the
.storage-layouts
directory). I believe this will also encourage us to properly look at the (files representing the) storage changes in a PR, which I already found myself not doing.I've also improved that second (now only) check, and it will catch the addition of new files that have not had storage slots added to the repository (as was the case in #1288 and was missed).