Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reputation mining client fixes and improvements #540

Merged
merged 6 commits into from
Feb 14, 2019
Merged

Reputation mining client fixes and improvements #540

merged 6 commits into from
Feb 14, 2019

Conversation

elenadimitrova
Copy link
Contributor

@elenadimitrova elenadimitrova commented Feb 13, 2019 •
edited
Loading

  • Add babel polyfill to reputation client (It appears I broke that with the babel upgrade and reconfiguration work from Upgrade to babel 7 and resolve source map support failure in tests #510 )
  • Sets the local minerAddress property when private key is used (as well as when an actual minerAddress is used directly)
  • Remove the obsoleted startup options file and seed
  • Allows all Infura supported networks to be used not just rinkeby

@elenadimitrova elenadimitrova added this to the Sprint 19 milestone Feb 13, 2019
@elenadimitrova elenadimitrova self-assigned this Feb 13, 2019
@elenadimitrova elenadimitrova changed the title Add babel polyfill to reputation client Reputation mining client fixes and improvements Feb 13, 2019
area
area approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@area area left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Was it a deliberate choice to leave the dbPath parameter in ReputationMinerClient.js / ReputationMiner, and just remove it

@elenadimitrova elenadimitrova force-pushed the maintenance/fix-babel-config-in-client branch from ec7141a to a35bd8b Compare February 14, 2019 11:59
@elenadimitrova elenadimitrova merged commit 917c125 into develop Feb 14, 2019
@elenadimitrova elenadimitrova deleted the maintenance/fix-babel-config-in-client branch February 14, 2019 14:17
@elenadimitrova elenadimitrova mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@area area area approved these changes

Assignees

@elenadimitrova elenadimitrova

Labels
bug
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging this pull request may close these issues.
2 participants
@elenadimitrova @area