Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColonyExtensionMeta #982

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Add ColonyExtensionMeta #982

merged 5 commits into from
Oct 15, 2021

Conversation

kronosapiens
Copy link
Member

@kronosapiens kronosapiens commented Aug 16, 2021

Closes #977

Add the ColonyExtensionMeta base class for extensions, which provides meta transaction functionality as per #962.

Exiting extensions continue to inherit from ColonyExtension for storage alignment reasons (and implement meta transaction functionality in a one-off basis), but new extensions should all use this new base class.

@kronosapiens
Copy link
Member Author

Noting that we would like to add some (let's say 32) storage slot placeholders in case we need to add new storage to this base class down the road.

@kronosapiens kronosapiens force-pushed the maint/meta-extensions branch from 76be92b to 826ef79 Compare October 3, 2021 11:55
@kronosapiens kronosapiens force-pushed the maint/meta-extensions branch 2 times, most recently from ae9766d to 25ed4a6 Compare October 5, 2021 17:17
@kronosapiens kronosapiens force-pushed the maint/meta-extensions branch from 25ed4a6 to 2f61a81 Compare October 12, 2021 09:59
@kronosapiens kronosapiens merged commit 48dda78 into develop Oct 15, 2021
@kronosapiens kronosapiens deleted the maint/meta-extensions branch October 15, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ColonyExtensionMeta base class
2 participants