Faster tests #999
Merged
Faster tests #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronosapiens
force-pushed
the
maint/faster-tests
branch
6 times, most recently
from
d413609 to
4132f02
Compare
area
requested changes
Nov 17, 2021
kronosapiens
force-pushed
the
maint/faster-tests
branch
from
b92cf54 to
0fa712e
Compare
|
@area fair, I dropped it since I had dropped the resolver setup. But we can easily grab it from the extension contract itself. |
area
force-pushed
the
maint/faster-tests
branch
from
0fa712e to
fc3e6ba
Compare
area
force-pushed
the
maint/faster-tests
branch
from
fc3e6ba to
250cbde
Compare
|
I'm not convinced a build with these changes is meaningfully faster than a build without but we'll merge anyway. |
area
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up our test suite by removing redundant deployments & transactions, specifically the redundant network & metacolony deployments at the beginning of test suites (truffle's snapshotting feature appears to bring us back to the correct state automatically).
Non-rigorous profiling suggests that the tests are indeed faster, modulo any endogenous effect caused by Circle's infrastructure. See original and improved build times.