This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Add MetaMask/Infura workaround for pending transactions #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `HARDFORKS` defaults constant * Add `NETWORK_NAMES` defaults constant * Add tentative support for more chains for `getChainDefinition` * Rename `NETWORK_IDS` defaults constant to `CHAIN_IDS` * Use hardfork and network name constants `getChainDefinition`
* Add `await-transaction-mined` dependency * Define a method to get a pending MetaMask transaction and if necessary (given e.g. an Infura provider), wait for the transaction to be confirmed before getting it (otherwise, the provider will return null)
rdig
approved these changes
Jul 22, 2019
| @@ -122,11 +122,39 @@ export const HTTPS_PROTOCOL: string = 'https:'; | |||
| /* | |||
| * Chain IDs | |||
| */ | |||
| export const NETWORK_IDS: Object = { | |||
| export const CHAIN_IDS: Object = { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround for an Infura issue (that becomes a problem with our MetaMask implementation) as documented here and more specifically here.
The crux of our issue is that
purser-metamask'ssignTransactionmethod attempts to get the transaction that MetaMask sent in the callback ofsendTransaction, when it is pending. With most providers, thegetTransactionmethod will respond with the transaction when it is pending, but Infura recently started returning an empty response.The workaround involves attempting to get the transaction immediately, and if that fails, using a
web30.20.x-compatible package (await-transaction-mined) to wait for the transaction to be confirmed before getting the transaction.This PR also makes some improvements to various defaults as suggested in #261 .
Update chain defaults
HARDFORKSdefaults constantNETWORK_NAMESdefaults constantgetChainDefinitionNETWORK_IDSdefaults constant toCHAIN_IDSgetChainDefinitionAdd MetaMask/Infura workaround
await-transaction-mineddependency