-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt: Redesign Tx History tab #420
Comments
I agree with your general line of thought here (nitpick: not thread, we're all async here, but same principle). Since it seems that people are now seriously looking into polishing up the functionality in Qt, I am reminded of something (partly because you're correctly raising the point of how and where we persist data): we should move all user data to |
I see multiple problems with current implementation of "Tx History" tab in JoinMarket-Qt.
We can't just use wallet-tool's approach here, as it is slow. What I propose is that we base on that code, but cache the result in either: a) wallet file, b) some additional file (like, wallet.jmdat.cache), c) use the same history_file, but add wallet info for each tx. Then, when new wallet is loaded, it could in some background thread analyze wallet history and slowly populate the table in "Tx History" tab (some indicator that tx history is being still analyzed would be needed, of course). Also, instead of using existing
persistTxToHistory
approach, it could be updated when wallet balance is automatically refreshed. This would also automatically add to tx history transactions potentially made by some other wallet controlling private keys of specific JM wallet. See also my comments on #414.The text was updated successfully, but these errors were encountered: