-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder the tabs in Qt #1013
Reorder the tabs in Qt #1013
Conversation
dc8f802
to
c1e368c
Compare
"Tx History" currently has very basic quick'n'dirty implementation, users may not see there what they expect, so it likely should be just before "Settings" at the end, see #420.
For comparison - Bitcoin Core GUI has "Overview, Send, Receive, Transactions", where "Transactions" is history, and coins (UTXOs) are available from manual coin selection button as additional dialog from "Send" tab. Another idea I have for a long time, but which is out of scope for this PR, and IIRC not everybody liked it, was to have instead of single "Coinjoins" tab a separate "Send" and "Tumble" tabs, because in single send you can send also non-cj transactions. |
c1e368c
to
bc71997
Compare
Makes sense, PR updated accordingly. |
@kristapsk agree with this:
It is weird to make simple, direct transactions from the "Coinjoins" tab. |
I also agree that there is a lot of improvement can be done for the UI of the Coinjoins tab. I think we should probably create a new issue to track this item, and move our discussions there. As this improvement is outside the scope of this PR. Thanks :) |
I also agree that discussions about "Coinjoins" tab specifically is out of scope of this PR. |
Any objections against merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bc71997
The current ordering of the tabs in Qt feels very strange. For example, the "Settings" tab is usually the last tab in most applications, while it's the 2nd tab in JoinMarket-Qt.
This PR reorders the tabs from "JM Wallet, Settings, Coinjoins, Tx History, Coins" to "JM Wallet, Tx History, Coinjoins, , Coins, Settings".
I made the new ordering of the tabs by consulting the Electrum wallet, which has the tab orders of "History, Send, Coins".