Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the tabs in Qt #1013

Merged

Conversation

BitcoinWukong
Copy link
Contributor

@BitcoinWukong BitcoinWukong commented Sep 9, 2021

The current ordering of the tabs in Qt feels very strange. For example, the "Settings" tab is usually the last tab in most applications, while it's the 2nd tab in JoinMarket-Qt.

This PR reorders the tabs from "JM Wallet, Settings, Coinjoins, Tx History, Coins" to "JM Wallet, Tx History, Coinjoins, , Coins, Settings".

I made the new ordering of the tabs by consulting the Electrum wallet, which has the tab orders of "History, Send, Coins".

@kristapsk
Copy link
Member

"Tx History" currently has very basic quick'n'dirty implementation, users may not see there what they expect, so it likely should be just before "Settings" at the end, see #420.

I made the new ordering of the tabs by consulting the Electrum wallet

For comparison - Bitcoin Core GUI has "Overview, Send, Receive, Transactions", where "Transactions" is history, and coins (UTXOs) are available from manual coin selection button as additional dialog from "Send" tab.

Another idea I have for a long time, but which is out of scope for this PR, and IIRC not everybody liked it, was to have instead of single "Coinjoins" tab a separate "Send" and "Tumble" tabs, because in single send you can send also non-cj transactions.

@BitcoinWukong
Copy link
Contributor Author

"Tx History" currently has very basic quick'n'dirty implementation, users may not see there what they expect, so it likely should be just before "Settings" at the end, see #420.

Makes sense, PR updated accordingly.

@openoms
Copy link
Contributor

openoms commented Sep 10, 2021

@kristapsk agree with this:

Another idea I have for a long time, but which is out of scope for this PR, and IIRC not everybody liked it, was to have instead of single "Coinjoins" tab a separate "Send" and "Tumble" tabs, because in single send you can send also non-cj transactions.

It is weird to make simple, direct transactions from the "Coinjoins" tab.

@BitcoinWukong
Copy link
Contributor Author

@kristapsk agree with this:

Another idea I have for a long time, but which is out of scope for this PR, and IIRC not everybody liked it, was to have instead of single "Coinjoins" tab a separate "Send" and "Tumble" tabs, because in single send you can send also non-cj transactions.

It is weird to make simple, direct transactions from the "Coinjoins" tab.

I also agree that there is a lot of improvement can be done for the UI of the Coinjoins tab. I think we should probably create a new issue to track this item, and move our discussions there. As this improvement is outside the scope of this PR. Thanks :)

@kristapsk
Copy link
Member

I also agree that discussions about "Coinjoins" tab specifically is out of scope of this PR.

@kristapsk
Copy link
Member

Any objections against merging this?

Copy link
Member

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bc71997

@kristapsk kristapsk merged commit 658952e into JoinMarket-Org:master Oct 9, 2021
@BitcoinWukong BitcoinWukong deleted the pr/wukong--reorder-tabs branch December 10, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants