Fix some internal dependencies #1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* txtorcon is used by jmbase too, not only jmdaemon * fidelity_bond_sanity_check() is used by jmclient, which should not depend on jmdaemon
|
This clearly works, but as per my comment, I don't think we really need this as a separate module (especially in |
|
Closing in favour of #1549. |
kristapsk
added a commit
that referenced
this pull request
Sep 15, 2023
47bc77f Fix some internal dependencies (Kristaps Kaupe) Pull request description: Alternative to #1543 (see [this comment](#1541 (comment))). * `txtorcon` is used by `jmbase` too, not only `jmdaemon`; * get rid of `jmdaemon` dependency in `jmclient`. Fixes #1540. Fixes #1541. ACKs for top commit: AdamISZ: utACK 47bc77f Tree-SHA512: f0c60172d286d5b8baeb46288291d3a7ade1a7ed4d7945cd4f11a7ed04aa118a665dee0c6da0ee346b6a8c5270d2616ad3a31bb37dcbcf027b0d844566793bcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txtorconis used byjmbasetoo, not onlyjmdaemonfidelity_bond_sanity_check()is used byjmclient, which should not depend onjmdaemonFixes #1540.
Fixes #1541.